bwatford Posted July 14, 2023 Clone Share Posted July 14, 2023 Is it possible to get a field to add a border to an image inside the image control popup where you resize or float the image? Would be much easier to do it from there without going into the source. Link to comment Share on other sites More sharing options...
Eric Posted July 14, 2023 Clone Share Posted July 14, 2023 I can take a look. It will highly depend on how Invision implemented their custom image handling CKEditor plugin and whether there are any extension points. Link to comment Share on other sites More sharing options...
Malkavian Grin Posted July 14, 2023 Clone Share Posted July 14, 2023 So, I had a little time and this is something I'd like to see, so I did a little mockup using pre-existing CSS from Baldr. This: Produces this: Link to comment Share on other sites More sharing options...
Eric Posted July 14, 2023 Clone Share Posted July 14, 2023 The primary issue regarding feasibility is whether making the changes to the form (and the resulting JS processing thereof) can be done without directly modifying Invision-provided code, since those modifications would get overwritten with the routine patch cycle. Link to comment Share on other sites More sharing options...
Malkavian Grin Posted July 14, 2023 Clone Share Posted July 14, 2023 Mmm, I hadn't thought about that. You don't want to be adding this stuff in with every patch. What if that functionality was added via a toolbar button? The only issue is whether the toolbar buttons (and js) are also just Invision plugins, in which that wouldn't work cause they'd just be overwrote. If those ideas don't work, what about adding it as a control+right-click option on the menu? Link to comment Share on other sites More sharing options...
Eric Posted July 14, 2023 Clone Share Posted July 14, 2023 Writing a replacement for their pre-built plugin is possible, but not high on my to-do list 🙂 The context menus are likewise driven off plugins, so... Yeah. Link to comment Share on other sites More sharing options...
Malkavian Grin Posted July 14, 2023 Clone Share Posted July 14, 2023 That's fair. We appreciate you looking into it! Link to comment Share on other sites More sharing options...
Eric Posted July 16, 2023 Clone Share Posted July 16, 2023 They have a hook and template in place, but only for border width, not color or radius. 😞 Link to comment Share on other sites More sharing options...
Malkavian Grin Posted July 17, 2023 Clone Share Posted July 17, 2023 2 hours ago, Eric said: They have a hook and template in place, but only for border width, not color or radius. 😞 Ah well. Baby-steps, yeah? 😉 Link to comment Share on other sites More sharing options...
Eric Posted July 25, 2023 Clone Share Posted July 25, 2023 After some thought, I think the right approach is to incorporate these asks under the Floating Block feature; since it was essentially just a div with one attribute wrapped around arbitrary content, it should be easy enough to add other attributes as well. Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now